Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting the module rulling #1

Merged
merged 17 commits into from
May 29, 2024
Merged

Getting the module rulling #1

merged 17 commits into from
May 29, 2024

Conversation

cableman
Copy link
Contributor

@cableman cableman commented May 15, 2024

Link to ticket

https://leantime.itkdev.dk/#/tickets/showTicket/1452

Description

This is Drupal module to communicate with LLM's.

Screenshot of the result

Screenshot from 2024-05-28 14-59-38

Checklist

  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.

Additional comments or questions

If you have any further comments or questions for the reviewer please add them here.

@cableman cableman force-pushed the develop branch 5 times, most recently from 1f2d8fb to 078cfab Compare May 15, 2024 13:41
@cableman cableman force-pushed the develop branch 2 times, most recently from 64ae36e to 6d64c32 Compare May 15, 2024 13:58
@cableman cableman force-pushed the develop branch 5 times, most recently from d1c5294 to beadae6 Compare May 24, 2024 10:42
Copy link
Contributor

@jekuaitk jekuaitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we should be consistent with the use of abbreviations in class names etc, i.e. LLM vs Llm vs LLModel vs LLModels.

llm_services.info.yml Outdated Show resolved Hide resolved
llm_services.links.task.yml Outdated Show resolved Hide resolved
llm_services.routing.yml Outdated Show resolved Hide resolved
src/Client/Ollama.php Outdated Show resolved Hide resolved
src/Drush/Commands/LlmServicesCommands.php Outdated Show resolved Hide resolved
src/Exceptions/LLMException.php Outdated Show resolved Hide resolved
src/Form/SettingsForm.php Outdated Show resolved Hide resolved
src/Model/MessageRoles.php Outdated Show resolved Hide resolved
src/Plugin/Derivative/LocalTask.php Show resolved Hide resolved
src/Drush/Commands/LlmServicesCommands.php Outdated Show resolved Hide resolved
Co-authored-by: Jeppe Kuhlmann Andersen <78410897+jekuaitk@users.noreply.github.com>
@cableman cableman force-pushed the develop branch 2 times, most recently from 101372b to 0f929f6 Compare May 28, 2024 11:26
@cableman cableman force-pushed the develop branch 2 times, most recently from 76bf595 to 7153bc2 Compare May 28, 2024 13:54
@cableman
Copy link
Contributor Author

I have tried to clean up the namespaces to better match what I try to do.

@cableman cableman force-pushed the develop branch 11 times, most recently from 5abe4d8 to 4626b01 Compare May 28, 2024 15:06
src/Commands/ModelChatCommand.php Show resolved Hide resolved
src/Commands/ModelChatCommand.php Outdated Show resolved Hide resolved
src/Commands/ModelChatCommand.php Show resolved Hide resolved
src/Commands/ModelCompletionCommand.php Show resolved Hide resolved
src/Commands/ProviderListCommand.php Outdated Show resolved Hide resolved
cableman and others added 2 commits May 29, 2024 08:50
Co-authored-by: Jeppe Kuhlmann Andersen <78410897+jekuaitk@users.noreply.github.com>
@cableman cableman merged commit 7285f6d into main May 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants